Handle broad visitor callback annotations#19
Open
jeet-dekivadia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
_VisitorFuncWrapperuses the first callback parameter annotation as an optional runtime filter. Concrete node annotations work, but callbacks with no annotation silently skip every node becauseinspect.Parameter.emptyis treated as a filter value. Callbacks annotated asAnyraiseTypeErrorbecausetyping.Anycannot be used withisinstance().This normalizes both cases to the existing visit-all path while leaving concrete typed callbacks unchanged. The regression covers an unannotated callback and an
Anycallback against the same expression tree.Validation:
git diff --check.venv/bin/python -m pytest test/stdlib/acceptance_test.py::test_broad_visitor_functions_visit_all_nodesuv format --diffuv run --all-extras --dev pytestuv run --all-extras --dev mypy heracles