adapter_test: define _USE_MATH_DEFINES on Windows, not just with MSVC#30
Open
chris-se wants to merge 1 commit into
Open
adapter_test: define _USE_MATH_DEFINES on Windows, not just with MSVC#30chris-se wants to merge 1 commit into
chris-se wants to merge 1 commit into
Conversation
MinGW/GCC also follows MSVC when it comes to the behavior of <cmath>, in that _USE_MATH_DEFINES must be defined for M_PI etc. to be defined as macros after including the header. Replace '#ifdef _MSC_VER' with a global check for '_WIN32' (which is also defined on 64bit Windows), so that this behavior happens on Windows universally, irrespective of the compiler used. Signed-off-by: Christian Seiler <c.seiler@luxflux.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MinGW/GCC also follows MSVC when it comes to the behavior of
<cmath>, in that_USE_MATH_DEFINESmust be defined forM_PIetc. to be defined as macros after including the header.Replace
#ifdef _MSC_VERwith a global check for_WIN32(which is also defined on 64bit Windows), so that this behavior happens on Windows universally, irrespective of the compiler used.