Fix Shared bool conversion#27
Merged
dprokoptsev merged 1 commit intoJun 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
Shared::operator bool()currently returns!state_, which makes a default-constructed emptySharedtruthy and a constructedSharedfalsey. That is the opposite of the existingget()semantics and the usual pointer-like contract used byoperator*/operator->.This changes the bool conversion to follow the underlying
IntrusivePtrvalidity and adds coverage in the existingsharedadapter test for both constructed and empty handles.Validation:
git diff --checkcmake -S . -B /tmp/corral-shared-bool-build -DSKIP_EXAMPLES=ON -DCORRAL_BOOST=''test/basic_test.cc+test/adapter_test.cc, then/tmp/corral-adapter-bool-build/corral_adapter_test shared-> all 16 assertions passed