Skip to content

25557: Fixes feature weights to use entire matrix if appropriate for similarity conviction and react details #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howsohazard merged 1 commit into from
May 28, 2026
Merged

25557: Fixes feature weights to use entire matrix if appropriate for similarity conviction and react details #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion module/conviction.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,11 @@
)

(declare (assoc
feature_weights (get hyperparam_map "featureWeights")
feature_weights
(if (size (get hyperparam_map "featureMdaMap"))
(get hyperparam_map "featureMdaMap")
(get hyperparam_map "featureWeights")
)
feature_deviations (get hyperparam_map "featureDeviations")
))

Expand Down
3 changes: 1 addition & 2 deletions module/details.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,7 @@

feature_deviations (get hyperparam_map "featureDeviations")
feature_weights
;only use featureMdaMap weights if there are action_features provided
(if (and (size (get hyperparam_map "featureMdaMap")) (size action_features))
(if (size (get hyperparam_map "featureMdaMap"))
(get hyperparam_map "featureMdaMap")
(get hyperparam_map "featureWeights")
)
Expand Down
2 changes: 1 addition & 1 deletion unit_tests/ut_h_rebalance_features.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@
;geomean
0
;weights of cases (order isn't relevant since distance/surprisal to each is same)
[1 2]
(normalize [1 2])
)
))

Expand Down
Loading