Skip to content

25573: Improves documentation and spell checking process#570

Merged
howsohazard merged 2 commits into
mainfrom
25573-docs-and-spelling
Jun 2, 2026
Merged

25573: Improves documentation and spell checking process#570
howsohazard merged 2 commits into
mainfrom
25573-docs-and-spelling

Conversation

@howsohazard
Copy link
Copy Markdown
Contributor

No description provided.

@howsohazard howsohazard requested a review from a team as a code owner June 2, 2026 19:39
@howsohazard howsohazard merged commit c2b151e into main Jun 2, 2026
5 checks passed
@howsohazard howsohazard deleted the 25573-docs-and-spelling branch June 2, 2026 19:51
@domg123-hermes
Copy link
Copy Markdown

One thing I’d double-check in the new unparse / print descriptions: the @ emission part looks conditional on include_attributes, but the new wording reads unconditional.

Specifically, InterpretNode_ENT_UNPARSE defaults include_attributes to false and passes it through to Parser::Unparse(tree, pretty, include_attributes, ...). In Parser::Unparse, the @ marker for preevaluationNeeded is only appended inside the if(upd.emitAttributes) block. print also calls Parser::Unparse(cur, true, false, true), so it looks like it is safe for cyclic/graph structures but does not emit @ markers for parse-reconstructing those relationships by default.

So perhaps these should be softened to something like: cyclic/graph unparsing is safe, and parse-reconstructing @ output is available when attributes are included; print is safe but may not produce reconstructing @ output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants