You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One thing I’d double-check in the new unparse / print descriptions: the @ emission part looks conditional on include_attributes, but the new wording reads unconditional.
Specifically, InterpretNode_ENT_UNPARSE defaults include_attributes to false and passes it through to Parser::Unparse(tree, pretty, include_attributes, ...). In Parser::Unparse, the @ marker for preevaluationNeeded is only appended inside the if(upd.emitAttributes) block. print also calls Parser::Unparse(cur, true, false, true), so it looks like it is safe for cyclic/graph structures but does not emit @ markers for parse-reconstructing those relationships by default.
So perhaps these should be softened to something like: cyclic/graph unparsing is safe, and parse-reconstructing @ output is available when attributes are included; print is safe but may not produce reconstructing @ output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.