fix: prevent MissingGreenlet error on task board query#20
Merged
Conversation
Change sub_tasks, comments, and parent_task relationships to lazy="noload" to avoid recursive selectin loading that breaks the async greenlet context. Guard to_dict() counts against unloaded relationships.
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate SQLAlchemy async MissingGreenlet errors encountered when querying tasks for the Kanban board by preventing implicit relationship loading during serialization.
Changes:
- Switched
Task.parent_task,Task.sub_tasks, andTask.commentsrelationships fromlazy="selectin"tolazy="noload". - Updated
Task.to_dict()to only computesub_tasks_count/comments_countwhen the relationships appear to be already loaded.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
167
to
175
| parent_task: Mapped["Task | None"] = relationship( | ||
| "Task", remote_side=[id], foreign_keys=[parent_task_id] | ||
| "Task", remote_side=[id], foreign_keys=[parent_task_id], lazy="noload" | ||
| ) | ||
| sub_tasks: Mapped[list["Task"]] = relationship( | ||
| "Task", foreign_keys=[parent_task_id], lazy="selectin" | ||
| "Task", foreign_keys=[parent_task_id], lazy="noload" | ||
| ) | ||
| comments: Mapped[list["Comment"]] = relationship( | ||
| "Comment", back_populates="task", lazy="selectin" | ||
| "Comment", back_populates="task", lazy="noload" | ||
| ) |
Comment on lines
+218
to
+219
| "sub_tasks_count": len(self.sub_tasks) if "sub_tasks" in self.__dict__ and self.sub_tasks else 0, | ||
| "comments_count": len(self.comments) if "comments" in self.__dict__ and self.comments else 0, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recursive selectin loading on sub_tasks/comments caused greenlet context loss. Changed to noload.