refactor: idempotent AlertStore + simplify DeliveryAttempt#804
Merged
refactor: idempotent AlertStore + simplify DeliveryAttempt#804
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexluong
force-pushed
the
alex/idempotent-alert-store
branch
from
b60e495 to
23c5010
Compare
Replace INCR/GET with SADD/SCARD on a Redis Set keyed by attemptID. Replayed messages no longer double-count consecutive failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace DeliveryAttempt fields (Success, DeliveryTask, DeliveryResponse, Timestamp) with models.Attempt and models.Event. Success is derived from Attempt.Status, delivery response from Attempt.ResponseData. Simplifies messagehandler by removing manual error extraction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexluong
force-pushed
the
alex/idempotent-alert-store
branch
from
23c5010 to
e5e3b51
Compare
alexluong
changed the title
alexbouchardd
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INCR/GETwithSADD/SCARDon a Redis Set keyed byattemptID— replayed messages are a no-opmodels.Attempt+models.Eventdirectly instead ofSuccess bool,*DeliveryTask,DeliveryResponse,Timestamp— eliminates manual error extraction in messagehandlerNo alert payload schema changes. Redis key scheme changes from
{dp}:alert:{dest}:consecutive_failuresto{dp}:alert:{dest}:cf— old keys expire within 24h, no migration needed.Test plan
make test/e2e)🤖 Generated with Claude Code