feat: switch delivery metadata timestamp from Unix to ISO 8601#803
Merged
feat: switch delivery metadata timestamp from Unix to ISO 8601#803
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- timestamp: Unix seconds → RFC3339 (e.g., 2021-01-01T00:00:00Z) - timestamp-ms: Unix milliseconds → RFC3339Nano (e.g., 2021-01-01T00:00:00.123456789Z) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexluong
force-pushed
the
feat/iso-timestamp-metadata
branch
from
9b779d9 to
904a6ac
Compare
Replace AssertTimestampIsUnixSeconds with AssertTimestampIsISO8601 across all provider test asserters. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The webhook-timestamp header is spec-mandated Unix seconds, separate from our metadata timestamp format. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The signature header t= uses Unix (for signing), while the timestamp header is now ISO 8601. These are intentionally different formats. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexbouchardd
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timestampmetadata from Unix seconds (1609459200) to ISO 8601 (2021-01-01T00:00:00Z) using Go'stime.RFC3339formatTest plan
TestMakeMetadata_*tests pass (6/6)🤖 Generated with Claude Code