Skip to content

Conversation

@Danielhiversen
Copy link
Member

Breaking change

Proposed change

Add Tibber binary sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds binary sensor support to the Tibber integration for monitoring EV charger status through the Tibber Data API. The implementation follows the existing sensor platform pattern and adds three binary sensors: connector status (plug), charging status (battery charging), and device status (power).

Key Changes

  • New binary sensor platform with three sensors for Tibber Data API devices
  • Translation strings for the new binary sensor entities
  • Removal of unnecessary debug logging from sensor platform

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
homeassistant/components/tibber/__init__.py Adds Platform.BINARY_SENSOR to the PLATFORMS list
homeassistant/components/tibber/binary_sensor.py New file implementing binary sensors for connector, charging, and device status using the Data API coordinator
homeassistant/components/tibber/strings.json Adds translation entries for the three new binary sensors
homeassistant/components/tibber/sensor.py Removes debug log statement when sensor is not found in mapping (minor cleanup)

Comment on lines 26 to 40
BinarySensorEntityDescription(
key="connector.status",
translation_key="connector_status",
device_class=BinarySensorDeviceClass.PLUG,
),
BinarySensorEntityDescription(
key="charging.status",
translation_key="charging_status",
device_class=BinarySensorDeviceClass.BATTERY_CHARGING,
),
BinarySensorEntityDescription(
key="onOff",
translation_key="device_status",
device_class=BinarySensorDeviceClass.POWER,
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what kind of device is this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heaters

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heaters on batteries?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, regular indoor heaters (For example a heatpump).
The devices provide by the API will show information about EV chargers, EVs, home batteries and heaters

@home-assistant home-assistant bot marked this pull request as draft January 6, 2026 16:22
@home-assistant
Copy link

home-assistant bot commented Jan 6, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@Danielhiversen Danielhiversen marked this pull request as ready for review January 6, 2026 17:34
@home-assistant home-assistant bot requested a review from joostlek January 6, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants