Switchbot Cloud: Add new supported device Ai Art Frame #160355
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @SeraphicRav, @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
requested changes
Jan 6, 2026
Comment on lines
+46
to
+47
| self.access_tokens: deque[str] = deque() | ||
| self.access_tokens.append("switchbot_art_frame_token") |
Comment on lines
+55
to
+57
| async def async_update(self) -> None: | ||
| """Async update.""" | ||
| self._attr_image_last_updated = datetime.datetime.now() |
| super().__init__(api, device, coordinator) | ||
| self.access_tokens: deque[str] = deque() | ||
| self.access_tokens.append("switchbot_art_frame_token") | ||
| self._image_content = b"" |
Comment on lines
+59
to
+68
| async def download_image(self) -> None: | ||
| """Download image.""" | ||
| if not isinstance(self.image_url, str) or len(self.image_url.strip()) == 0: | ||
| self._image_content = b"" | ||
| return | ||
| timeout = ClientTimeout(total=30, connect=5, sock_read=20) | ||
| session = async_get_clientsession(self.coordinator.hass) | ||
| async with session.get(self.image_url, timeout=timeout) as response: | ||
| response.raise_for_status() | ||
| self._image_content = await response.read() |
Member
There was a problem hiding this comment.
This is a service specific call, this should exist in the library
Comment on lines
+20
to
+46
| @pytest.fixture | ||
| def mock_api(): | ||
| """Fixture for mock SwitchBotAPI.""" | ||
| return Mock(name="SwitchBotAPI") | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def mock_device(): | ||
| """Fixture for mock Device/Remote.""" | ||
| return Mock(name="Device", device_id="test_device_123") | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def mock_coordinator(): | ||
| """Fixture for mock SwitchBotCoordinator.""" | ||
| coordinator = Mock(name="SwitchBotCoordinator") | ||
| coordinator.hass = Mock(name="HASS") | ||
| coordinator.data = None | ||
| return coordinator | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def image_entity(mock_api, mock_device, mock_coordinator): | ||
| """Fixture for SwitchBotCloudImage entity.""" | ||
| return SwitchBotCloudImage( | ||
| api=mock_api, device=mock_device, coordinator=mock_coordinator | ||
| ) |
Member
There was a problem hiding this comment.
Internals shouldn't be created independently, instead patch the library to return what we expect and check the state machine
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This is a digital photo frame; you can switch pictures using buttons.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: