-
-
Notifications
You must be signed in to change notification settings - Fork 36.4k
Replace openevse backend library #160325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace openevse backend library #160325
Conversation
This allows us to get serial number (and be fully async)
epenet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a link to the changelog of the new library, so that reviewers do not need to do the hunt...
Also, CI is failing
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Changelog added. |
|
I believe this is actually a trunk regression, but either way fixed it. (py-vapid pushed a broken version). |
|
Why do we need py-vapid bumped? |
|
@joostlek - AFAICT, uv in a fresh install is pulling in py-vaapid 1.9.3 by default, which breaks uv (due to a hardcoded symlink). This pins py-vaapid to 1.9.2 which was the last working version. |
|
Yea I see now, but we should do this in a separate PR as this isn't related to the current PR |
Then the pin is unlinked to this PR |
|
Pushed the cherry pick to #160329 - but this is a draft PR where I'm just working through getting it green :). |
|
openrgb test failure looks flaky and doesn't repro on my machine. |
|
Sorry for the noise, tried to use a merge commit to retrigger tests, and screwed it up (which caused a bunch of commits to get added). And I don't have permission to remove reviewers. |
edenhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @c00w 👍
This allows us to get serial number (and be fully async)
Proposed change
This switches us to a more modern library, which contains serial number (so in a later PR, we can correctly identify devices). This also simplifies some of the async code, since the underlying library is async.
Changelog - https://github.com/firstof9/python-openevse-http/releases (Although for notes, we're switching the whole library - the substance of the changes is 1) this is fully async and uses aiohttp under the hood, 2) this uses json, and not the weird hybrid json xml thing the previous dependency used, and 3) it supports a lot more information, as well as push actions, 4) we're not using it fully but this partly switches us to local pushing instead of polling, another PR to finish that).
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: