Skip to content

Conversation

@c00w
Copy link
Contributor

@c00w c00w commented Jan 5, 2026

This allows us to get serial number (and be fully async)

Proposed change

This switches us to a more modern library, which contains serial number (so in a later PR, we can correctly identify devices). This also simplifies some of the async code, since the underlying library is async.

Changelog - https://github.com/firstof9/python-openevse-http/releases (Although for notes, we're switching the whole library - the substance of the changes is 1) this is fully async and uses aiohttp under the hood, 2) this uses json, and not the weird hybrid json xml thing the previous dependency used, and 3) it supports a lot more information, as well as push actions, 4) we're not using it fully but this partly switches us to local pushing instead of polling, another PR to finish that).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

This allows us to get serial number (and be fully async)
epenet
epenet previously requested changes Jan 5, 2026
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the changelog of the new library, so that reviewers do not need to do the hunt...

Also, CI is failing

@home-assistant home-assistant bot marked this pull request as draft January 5, 2026 19:33
@home-assistant
Copy link

home-assistant bot commented Jan 5, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet epenet changed the title openevse: Switch to firstof9/python-openevse-http Replace openevse backend library Jan 5, 2026
@c00w
Copy link
Contributor Author

c00w commented Jan 5, 2026

Changelog added.

@c00w
Copy link
Contributor Author

c00w commented Jan 5, 2026

I believe this is actually a trunk regression, but either way fixed it. (py-vapid pushed a broken version).

@joostlek
Copy link
Member

joostlek commented Jan 5, 2026

Why do we need py-vapid bumped?

@c00w
Copy link
Contributor Author

c00w commented Jan 5, 2026

@joostlek - AFAICT, uv in a fresh install is pulling in py-vaapid 1.9.3 by default, which breaks uv (due to a hardcoded symlink). This pins py-vaapid to 1.9.2 which was the last working version.

@joostlek
Copy link
Member

joostlek commented Jan 5, 2026

Yea I see now, but we should do this in a separate PR as this isn't related to the current PR

@epenet
Copy link
Contributor

epenet commented Jan 5, 2026

@joostlek - AFAICT, uv in a fresh install is pulling in py-vaapid 1.9.3 by default, which breaks uv (due to a hardcoded symlink). This pins py-vaapid to 1.9.2 which was the last working version.

Then the pin is unlinked to this PR
It should be a standalone PR "pin py-vaapid to fix invalid xyz"

@c00w
Copy link
Contributor Author

c00w commented Jan 5, 2026

Pushed the cherry pick to #160329 - but this is a draft PR where I'm just working through getting it green :).

@c00w c00w marked this pull request as ready for review January 6, 2026 01:54
@home-assistant home-assistant bot requested a review from epenet January 6, 2026 01:54
@c00w
Copy link
Contributor Author

c00w commented Jan 6, 2026

openrgb test failure looks flaky and doesn't repro on my machine.

@c00w c00w requested review from a team, Danielhiversen and hunterjm as code owners January 6, 2026 05:39
@c00w c00w requested a review from pvizeli as a code owner January 6, 2026 05:39
@c00w
Copy link
Contributor Author

c00w commented Jan 6, 2026

Sorry for the noise, tried to use a merge commit to retrigger tests, and screwed it up (which caused a bunch of commits to get added). And I don't have permission to remove reviewers.

Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @c00w 👍

@edenhaus edenhaus merged commit fde9bd9 into home-assistant:dev Jan 7, 2026
123 of 124 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants