Updated the starlingbank integration to use the newer starlingbankapi package, the old starlingbank package having been abandoned since 2019.

[richkershaw]

Proposed change

The old starlingbank Python package hasn't been updated since 2019, so in order to add support for the more recent Spaces savings pot feature in Starling's API, I've forked it as (starlingbankapi)[https://github.com/richkershaw/starlingbankapi/] and created a new (PyPI package)[https://pypi.org/project/starlingbankapi/] just in case the original author @dullage decides to pick it back up again. The new code also adds the space_name config option to give access to that feature in the new package.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: [https://github.com/Enhance Starling bank integration with new options via updated starlingbankapi package home-assistant.io#42836]
• Link to developer documentation pull request:
• Link to frontend pull request:

Checklist

• I understand the code I am submitting and can explain how it works.
• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.
• Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi @richkershaw

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[home-assistant]

Hi @richkershaw

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Stale

[zweckj]

Hi,

• have you tried contacting the existing library owner if he would be willing to add you as a maintainer before forking? We generally try to avoid forking unless proven there's no other way
• we only allow changes to are necessary for a library change to work, the new CONF is not that
• this integration still uses YAML, according to https://github.com/home-assistant/architecture/blob/master/adr/0010-integration-configuration.md#decision we no longer allow changes to the YAML config, so the integration would need to migrate to a config flow first, it would be very much appreciated if you were willing to do that

Thanks!

[richkershaw]

@zweckj - thanks for the review.

• have you tried contacting the existing library owner if he would be willing to add you as a maintainer before forking? We generally try to avoid forking unless proven there's no other way

Yes, several weeks ago - no activity on the repo since 2019, and no reply from the author.

• we only allow changes to are necessary for a library change to work, the new CONF is not that

OK, no problem - so two pull requests, one for the library change and one for the new CONF?

• this integration still uses YAML, according to https://github.com/home-assistant/architecture/blob/master/adr/0010-integration-configuration.md#decision we no longer allow changes to the YAML config, so the integration would need to migrate to a config flow first, it would be very much appreciated if you were willing to do that

Will do - on my to-do list, thanks.

[zweckj]

OK, no problem - so two pull requests, one for the library change and one for the new CONF?

yes, with the caveat, that you'll need to implement a config flow first

[richkershaw]

Closing this PR ahead of splitting into several PRs and implementing a config flow.