Ready sessions prior to parent append in tests#768
Open
lejeunerenard wants to merge 1 commit intomainfrom
Open
Ready sessions prior to parent append in tests#768lejeunerenard wants to merge 1 commit intomainfrom
lejeunerenard wants to merge 1 commit intomainfrom
Conversation
Remove useless `await`ing of sessions noticed while finding instances of sessions potentially not being ready in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests could flake due to the
.append()on the parent core resolving before the named session fully opened. This included the block when the tests were assuming it wasn't included.Also remove useless
awaiting of sessions noticed while finding instances of sessions potentially not being ready in tests.