Skip to content
This repository was archived by the owner on Jul 18, 2026. It is now read-only.

add hashing to dupe check - #4

Open
azt3k wants to merge 11 commits into
hoho:masterfrom
azt3k:master
Open

add hashing to dupe check#4
azt3k wants to merge 11 commits into
hoho:masterfrom
azt3k:master

Conversation

@azt3k

@azt3k azt3k commented Apr 23, 2017

Copy link
Copy Markdown

No description provided.

azt3k added 4 commits April 11, 2017 10:17
added hash lookup
updated deps
restored original package.json with new deps
@hoho

hoho commented Apr 24, 2017

Copy link
Copy Markdown
Owner
  1. Files in the Gulp stream do not necessarily exist on the disk. And this hasher reads the disk for every file with no ability to opt-out.
  2. The tests fail.
  3. I actually do not understand the purpose of this change at all.

@azt3k

azt3k commented May 8, 2017

Copy link
Copy Markdown
Author
  • Files in the Gulp stream do not necessarily exist on the disk. And this hasher reads the disk for every file with no ability to opt-out
    • Fair call - it reads from the buffer now
  • The tests fail.
    • Fixed
  • I actually do not understand the purpose of this change at all.
    • The current implementation doesn't dedupe on contents
    • We needed a deduper to use gulp-cache properly otherwise duplicate images with diff filenames are seen as the same file due to the hash based index and don't end up in the desired output location - this patch solves our issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants