This repository was archived by the owner on Aug 13, 2024. It is now read-only.
more robust json generation#110
Open
divinity76 wants to merge 2 commits into
Open
Conversation
concatenating strings into json is... unreliable. I think the original code was written that way because definedTags and freeformTags *must* be object, not array, or be rejected as invalid, and by default json_encode makes them array, not object, the original code fixed it by writing the json manually, the new code fix it with 'definedTags' =>(object)array()
Author
|
this patch is now confirmed to work :D i just got my server yesterday with this patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concatenating strings into json is... unreliable.
I think the original code was written that way because definedTags and freeformTags must be object, not array, or be rejected as invalid, and by default json_encode makes them array, not object, the original code fixed it by writing the json manually, the new code fix it with 'definedTags' =>(object)array()
$displayNameisfoo"barthen the original code would make the json"displayName": "foo"bar",which is a syntax error, and oci would reject the json as malformed, the new code correctly encodes it into"displayName": "foo\"bar"and the json remains syntactically valid