fix: extend BP_BIG_ENDIAN auto-detection to cover TI ARM CGT - #84
Merged
Merged
Conversation
The existing check only recognised GCC/Clang's __BYTE_ORDER__ / __ORDER_BIG_ENDIAN__ pair. TI's ARM CGT compiler (used with --be32 for big-endian Cortex-R targets such as the TMS570) does not define those macros; it defines __BIG_ENDIAN__ instead. Without this fix the dual-path codegen (endian="both") falls through to the #ifndef BP_BIG_ENDIAN (little-endian byte-pointer) branch on TI big-endian targets, producing incorrect encode/decode results for multi-byte fields. Add __BIG_ENDIAN__ as a second detection arm so BP_BIG_ENDIAN is set correctly on TI CGT and other toolchains that follow the same convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing check only recognised GCC/Clang's BYTE_ORDER / ORDER_BIG_ENDIAN pair. TI's ARM CGT compiler (used with --be32 for big-endian Cortex-R targets such as the TMS570) does not define those macros; it defines BIG_ENDIAN instead.
Without this fix the dual-path codegen (endian="both") falls through to the #ifndef BP_BIG_ENDIAN (little-endian byte-pointer) branch on TI big-endian targets, producing incorrect encode/decode results for multi-byte fields.
Add BIG_ENDIAN as a second detection arm so BP_BIG_ENDIAN is set correctly on TI CGT and other toolchains that follow the same convention.