Repository navigation
Promotion polish: release workflow, PyPI, README, social preview - #19
Merged
Merged
Conversation
…view Add tag-triggered release workflow (Windows PyInstaller exe + trusted PyPI publish), refresh README for v1.0 launch, generate social preview image, fold in Dependabot bumps, and remove deprecated root entry scripts.
Replace placeholder and legacy screenshots with Joel-approved files (byte-for-byte). Update README alt text and social preview note in PR.
hippi345
marked this pull request as ready for review
September 28, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the v1.0.0 launch: GitHub Release + PyPI trusted publishing workflow, README/pitch polish, repo social preview asset, Dependabot alignment, and removal of deprecated root scripts.
GitHub About (paste for Joel)
Description:
Shows your currently playing Spotify track as a glass-style album-art tile on your desktop wallpaper (Windows, macOS, Linux).
Topics:
spotify,wallpaper,now-playing,album-art,desktop-customization,windows,macos,linux,python,mpris,smtcSocial preview
Upload
docs/social-preview.png(1280×640) via Settings → General → Social preview → Edit → Upload an image. The image is a clean app-generated frame (glass tile and typography only — no desktop wallpaper or other on-screen content).Superseded Dependabot PRs (close after merge)
actions/checkoutv4 → v7.github/workflows/ci.yml,.github/workflows/release.ymlactions/setup-pythonv5 → v7pytest8.4.2 → 9.1.1pyproject.toml,requirements-lock.txtpytest-cov6.3.0 → 7.1.0Left out: none — all four open Dependabot PRs were applied.
Root legacy scripts
Removed
spotifyWindows.pyandmacosSpotify.py(deprecated shims). The only code reference wastests/test_windows_entry_point_dpi.py(test removed); usenow-playing-windows/now-playing-macosconsole entry points instead.Release workflow
v*→ buildnow-playing-windows.exe(PyInstaller onwindows-latest) and attach to GitHub Release; build sdist/wheel and publish to PyPI via trusted publishing (pypienvironment).workflow_dispatchwithdry_run: true→ Windows exe uploaded as artifact only (no Release/PyPI).Local checks on this branch:
python -m build,twine check dist/*,pyinstaller packaging/now-playing-smoke.spec(Linux smoke).Draft good-first issues (not filed)
1. Add
now-playing --versionTitle: Expose package version on the CLI (
--version)Body:
pyproject.tomlis at1.0.0, butnow-playing --helphas no--version. Addimportlib.metadata.version("now-playing-desktops")incli.py(with a small test intests/test_cli.py) so support tickets and bug reports can cite the installed release.2. CI: PyInstaller smoke build on Linux
Title: Run
packaging/now-playing-smoke.specin CI afterpip install -e .Body:
packaging/now-playing-smoke.speccatches packaging/hook regressions without needing Windows runners. Add a short step toci.ymlafter the wheel build (installpyinstaller, run spec, assertdist/now-playing-smokeexists).3. Document Windows
.exevs pipx in README troubleshootingTitle: README: first-run notes for PyInstaller exe and pipx installs
Body: The Windows quick start mentions Releases and
pipx install now-playing-desktops. Add a troubleshooting row covering SmartScreen, missing WinRT/SMTC when not using the[windows]extra wheel, and where logs live (logging_setup.log_file_path()).4. Configurable tile corner / margin
Title: Optional env var for glass tile screen position
Body:
composer.pycenters the glass panel on the wallpaper. Some users want bottom-right like a widget. Add something likeNOW_PLAYING_TILE_ANCHOR(e.g.center,bottom-right) parsed inconfig.pyand applied in layout code, with unit tests intests/test_composer_layout_fonts.py.Manual steps for Joel
docs/social-preview.png(Settings → General → Social preview).now-playing-desktops, ownerhippi345, reponowPlayingDesktops, workflowrelease.yml, environmentpypi.pypienvironment under repo Settings → Environments (used by the publish job).git tag v1.0.0 && git push origin v1.0.0(do not push the tag until trusted publishing is configured).