Skip to content

Add Windows support #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leiflm wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Windows support #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f92f4d5
adds support for Windows
May 18, 2021
105a391
requirements:pexpect: Set min. version for Windows
May 18, 2021
a47ec93
setup.py: bump version number due to new feature
May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pexpect_serial/serial_spawn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@

"""

from pexpect import spawn
# pexpect.spawn is not supported on some systems (i.e. Windows(TM))
# See https://pexpect.readthedocs.io/en/stable/overview.html#pexpect-on-windows for details.
import os
if os.name in ['nt']:
Comment on lines +26 to +27

@leiflm leiflm May 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this condition is not even necessary. Using pexpect.fdexpect.fdspawn should be the right choice on any operating system.

To keep it "as is" as much as possible though, I've added this if/else conditional import statement here. Feel free to remove it and go solely with pexpect.fdexpect.fdspawn.

from pexpect.fdpexpect import fdspawn as spawn
else:
from pexpect import spawn
from pexpect.exceptions import ExceptionPexpect

__all__ = ['SerialSpawn']
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
pyserial
pexpect
pexpect>=4
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

setuptools.setup(
name='pexpect-serial',
version='0.1.0',
version='0.2.0',
author='High Wall',
author_email='hiwall@126.com',
description='pexpect with pyserial',
Expand Down