bugfix/437-performance-regression#451
Conversation
|
I reworked the v5 init path so the directive no longer relies on the old default |
wchmiel
left a comment
There was a problem hiding this comment.
I’ve tested the changes locally and it looks like the solution works and the bug has been fixed – well done ;) However, I think @karolkolodziej or someone involved more in maintaining the wrapper should check this, as there are some core changes here. I just have a few minor questions/requests.
KacperMadej
left a comment
There was a problem hiding this comment.
Trashing time-based guessing for loading is good improvement.
I'm still a bit rusty with this repo and a lot has changed since I was actively involved in the development, so please take my review with a grain of salt.
Could you point me to the performance test that we could use in the future to make sure it's not dropping back down after, let's say HC v13 release?
With HC v13 being available currently as a beta release - have you tested this PR with it? It's not a must have but would be nice to check this in advance - there can be a follow up task to take care of this to avoid blocking this PR.
| modules: () => [ | ||
| import('highcharts/esm/modules/map'), | ||
| import('highcharts/esm/modules/tilemap'), | ||
| import('highcharts/esm/modules/map').then(() => import('highcharts/esm/modules/tilemap')), |
There was a problem hiding this comment.
Importing modules/map twice is needed for something? If no, the line above should be safe to remove.
Fixed performance regression on multiple charts render, closes #437.