ci: scope release gate to the CI workflow run (not all check-runs)#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish workflow's
ci-gate("Verify CI passed") inspected every github-actions check-run on the release commit and failed if any was not completed/success. GitHub's own "Dependabot Updates" recompute posts aDependabotcheck-run (app.slug: github-actions) that sitsin_progressright after a dev-deps PR merges to main — so the gate failed and the release did not publish even though all real CI checks were green. This blocked the v0.13.0 release on 2026-06-16 (workaround: wait for the Dependabot run to finish, then re-run publish).Fix
Gate only on this repo's CI workflow (
ci.yml) run for the commit, viaactions/workflows/ci.yml/runs?head_sha=…, and require itsstatus == completed && conclusion == success. The CI run's conclusion issuccessonly when every CI job (Node matrix, Security audit, …) passed, so it's the authoritative signal — and it structurally excludes the unrelatedDependabotcheck-run.failure/cancelled).Dependabotcheck being in_progress.Workflow-only change; CI on this PR (src lint/typecheck/test) is unaffected. The gate itself only runs on
release: published, so it can't be exercised pre-merge — verified by reasoning + the API shape.