Repository navigation
fix(cli): audit clipped text beneath transparent composition hosts - #5400
Open
user-github-me wants to merge 1 commit into
Open
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visible text with a
clip-pathcan disappear from contrast checks when a transparent composition host sits above it. For example, addingclip-path: inset(0)leaves the rendered frame identical but makeshyperframes checkmiss a 1.16:1 contrast failure.Use the existing hit-stack probe for clipped text as well as intentional occlusion. It walks only through unpainted composition containers and stops at painted covers. Fully clipped text remains excluded.
Follows the reviewer's suggested follow-up on #5202.
Validation: six new visible-text regressions fail on unchanged main; all 70 contrast tests pass with the fix, including six real Chromium tests. Screenshots verify that an unchanged visible frame is audited and fully clipped text stays excluded. Seven isolated runs through the rebuilt, copied CLI report contrast failures for visible, partially revealed, ancestor-clipped, and nested-root text, and pass fully clipped, painted-cover, and readable-text controls. The source and packaged browser scripts match. Browser-check tests, full workspace and CLI builds, CLI typecheck, repository lint, formatting, test reachability, comment checks, and normal commit hooks pass.