Repository navigation
fix(parsers): recognize computed variable usage reads - #5218
Closed
user-github-me wants to merge 1 commit into
Closed
user-github-me wants to merge 1 commit into
user-github-me wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the careful write-up. The documented ways to read variables are the dot-call forms the scanner already covers, and we haven't seen a bracket-string getter or the values object used as a computed key in real compositions, so we'd rather not grow the scanner for those cases. Happy to revisit if a real composition hits it. — Rames |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Studio's variable usage report misses reads through
window.__hyperframes["getVariables"]()and can confidently label those declarations unused. It also skips a values alias used as the computed key of another object, leavingscanIncompletefalse despite the value escaping.Recognize a literal
"getVariables"member name and skip property-position identifiers only for noncomputed members. Bracket getter reads now cross-reference declared and undeclared ids like dot calls; computed-key escapes mark the existing report incomplete.Validation: