Repository navigation
fix(studio): undo keeps a reloaded GSAP edit undone and a newer gesture's look intact - #5035
Closed
miguel-heygen wants to merge 2 commits into
Closed
miguel-heygen wants to merge 2 commits into
miguel-heygen wants to merge 2 commits into
Conversation
…ment a newer gesture took
Edit accuracy: accurate 1562 (base branch 1562), smooth 1139 of thoseThe gate passes. Quarantined, measured but not gated (0) |
Collaborator
Author
|
Closing: browser runs on main and this branch showed no user-visible difference for any gesture that reaches these paths today. The branch stays for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This closes three gaps in how undo shows an edit that is still saving:
Why
The paint-back from the earlier change only undid what was on the element. A soft reload that had already run left the edited timeline in the preview. A late write of a painted-back edit ended by re-applying the look from press time, wiping anything drawn since.
How
reverted()is false again and later draws show at once.The confirm decision in
useEditHistoryActions(whether the server's undo stepped this edit) is not touched. That stays with #4937.Before / After
(captures attached before ready)
Test plan