Repository navigation
fix(ci): skill docs may name the project files a workflow writes - #4902
Merged
Merged
Conversation
miguel-heygen
marked this pull request as ready for review
October 2, 2026 13:49
Edit accuracy: accurate 1216 (base branch 1216), smooth 1110 of thoseThe gate passes. Quarantined, measured but not gated (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment-citation gate reads markdown, so it grades skill docs. Skill workflow docs name files that the workflow writes into the user's project at run time (
frame.md,STORYBOARD.md,SCRIPT.md,_role.md). Those files never exist in this repo, so every touched line naming one failed as "no such file in the repo".This adds them as one named list in
check-comment-citations.mjs. The exemption matches the bare name only: a repo path that merely ends in one of these names is still resolved and still fails when missing.Why
#3951 fixes 35 broken skill-doc links. Its "Comments" check fails on 13 lines it rewrote, all bare
frame.md,STORYBOARD.mdor_role.md. Any skill-doc PR touching such a line hits the same false failure.Test plan
skills/demo/frame.md, a repo path ending in a project-file name, still fails with "no such file".PROJECT_FILEScheck fails the first case; matching on the basename instead of the bare name fails the second.scripts/gate-probes/broken-citation.md) is unchanged and still reports both of its dead citations.Size
20 changed lines: one named list, one check, two tests. The whole fix is the exemption; nothing else in the gate changes.