Skip to content

fix(cli): require non-empty feedback repro commands - #4263

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/feedback-repro-command-validation
Sep 22, 2026
Merged

miguel-heygen merged 1 commit into
mainfrom
fix/feedback-repro-command-validation

Conversation

@heygengenesis

@heygengenesis heygengenesis Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require a non-whitespace command body after REPRO COMMAND: in CLI feedback
  • accept valid inline, multiline, and case-insensitive command forms
  • keep packet headers such as EXPECTED / ACTUAL: from satisfying an empty repro block
  • add focused regression coverage for the marker-only feedback seen in production

Verification

  • npx --yes bun@latest x vitest run packages/cli/src/utils/feedbackLint.test.ts (25 passed)
  • npx --yes bun@latest x oxlint packages/cli/src/utils/feedbackLint.ts packages/cli/src/utils/feedbackLint.test.ts
  • npx --yes bun@latest x oxfmt --check packages/cli/src/utils/feedbackLint.ts packages/cli/src/utils/feedbackLint.test.ts
  • npx --yes bun@latest run --cwd packages/cli typecheck
  • direct validator probe for empty and multiline command bodies

Genesis V2 session

Session

Session owner: miguel.sierra@heygen.com

Co-authored-by: GPT-5.6 Sol <noreply@openai.com>
Co-authored-by: miguel.sierra <miguel.sierra@heygen.com>
@miguel-heygen
miguel-heygen enabled auto-merge (squash) September 22, 2026 00:50
@miguel-heygen
miguel-heygen merged commit e568978 into main Sep 22, 2026
52 checks passed
@miguel-heygen
miguel-heygen deleted the fix/feedback-repro-command-validation branch September 22, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant