Repository navigation
fix(skills): stop mirroring skills into Codex and remove old mirror links - #4105
Merged
miguel-heygen merged 4 commits intoOct 2, 2026
Merged
Conversation
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The global skills mirror no longer creates a Codex-specific copy: Codex reads the universal
~/.agents/skillsstore, so a second copy made every skill show up twice.Why
Codex discovers the user-level universal skills store, so creating another Codex mirror causes duplicate skill discovery.
How
Add Codex to the universal-store reader capability set and skip it before directory creation or target replacement. Symlinks an earlier mirror left in the Codex skills dir (they resolve to the same Claude-store skill) are removed, but only when the universal store holds that skill and the Codex dir passes the same alias check every other destructive path runs; real directories and Windows copies carry no ownership proof, so they stay. Add isolated default and custom
CODEX_HOMEregression coverage.Size
Small on purpose: one gate in the skills mirror plus a cleanup of the links it used to create, with tests. Extending the skip to the other agents that read the universal store is a separate follow-up.
Test plan
Focused tests, formatting, lint, and diff checks pass. Package typecheck remains unverified because unrelated generated modules are absent in the local worktree.
Fixes #3995