Repository navigation
fix(cli): stop lambda deploy from pointing at a nonexistent --sam-template flag - #3879
Merged
Merged
Conversation
…-sam-template flag locateSamTemplate()'s error message and doc comment both promised a --sam-template CLI flag as an installed-package fallback, but no such flag was ever wired up anywhere in lambda.ts/deploy.ts/destroy.ts, and examples/aws-lambda/template.yaml isn't shipped in any published package either -- a dead-end escape hatch that just wasted users' time. Replace it with the honest requirement (matches repoRoot()'s own message): these commands need a HyperFrames monorepo checkout, or HYPERFRAMES_REPO_ROOT pointed at one.
miguel-heygen
force-pushed
the
fix/lambda-sam-template-error-hint
branch
from
October 2, 2026 13:11
25c0dd5 to
553d14e
Compare
miguel-heygen
changed the title
Edit accuracy: accurate 1216 (base branch 1216), smooth 1048 of thoseThe gate passes. Quarantined, measured but not gated (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hyperframes lambda deploytold users to "point --sam-template at your local copy" of the template. No--sam-templateflag exists in any lambda command, andexamples/aws-lambda/template.yamlis not shipped in any published package, so the advice was a dead end.repoRoot()'s own message: runhyperframes lambda deployfrom a HyperFrames repo checkout, or setHYPERFRAMES_REPO_ROOTto point at one.CodeUri(../../packages/aws-lambda/dist/handler.zip) is relative to the repo, so a copied-out template cannot work without the checkout around it.deploycallslocateSamTemplate();destroyis unaffected.Making
deploywork from a plain npm install is a separate, larger feature: the handler ZIP build aliases@hyperframes/{producer,engine,core}to repo source and pins versions from the root lockfile.Size
Small on purpose: one error message, one doc comment, and a regression test. The install-path feature above is out of scope.
Test plan
packages/cli/src/commands/lambda/sam.test.ts:locateSamTemplate()resolves an existing template, and its missing-template error mentionsHYPERFRAMES_REPO_ROOTand not--sam-template. 2/2 pass; restoring the old--sam-templatewording makes the second test fail.bunx oxfmt --checkon both changed files: clean.