fix(preview): prevent render processes outliving shutdown - #3710
Open
miguel-heygen wants to merge 1 commit into
Open
fix(preview): prevent render processes outliving shutdown#3710miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
Fallow audit reportFound 6 findings. Dead code (1)
Duplication (4)
Health (1)
Generated by fallow. |
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Orderly shutdown drain sequence, FFmpeg ownership registry with identity-verified cleanup, and draining latch are all well tested and correct. — Miga
miga-heygen
enabled auto-merge (squash)
September 8, 2026 18:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preview shutdown now closes render ownership before the server exits. Active Studio jobs are cancelled and awaited, late child registrations are terminated, and a later CLI run can recover only birth-identity-matched FFmpeg processes that became true OS orphans.
Live
--backgroundpreview owners remain protected. Recovery requires PPID 1 plus a recorded process identity, and it revalidates that identity before both graceful and forced termination. The original report lacked PID/PPID/command/status evidence, so this fixes the validated shutdown and crash window without claiming that the observed job was definitely orphaned rather than owned by a live background server.Validation
git diff --checkpassed.