fix(skills): bootstrap npm safely on Windows - #3705
Merged
Merged
Conversation
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Clean fix for the Windows npm.cmd shell injection vector — direct node+npm-cli.js invocation with proper path resolution and CI gate. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HyperFrames skill helpers can now bootstrap missing npm packages on Windows and Node 24 without failing at the
spawnSync("npm.cmd")boundary.Why
Direct
.cmdspawning without a shell is rejected on the reported Windows/Node 24 path. Enabling a shell would weaken the bootstrap's argv and lifecycle-script safety guarantees, so Windows now invokes npm's JavaScript CLI through Node instead.The earlier closed change did not update the published skill manifest or exercise the resolved command on a real Windows/Node 24 runner. This version includes both gates.
Related: #2321
How
npm_execpathfirst, then thenpm-cli.jsinstalled beside Node.npm_node_execpathorprocess.execPathwith an argv array and no shell.npmcommand and temporary--ignore-scriptsinstall contract.windows-latestwith Node 24; the Windows-only test launches the resolved npm CLI.Test plan
actionlintafter excluding three existing unrelatedSC2034warnings.skills/media-use/scripts/resolve.test.mjssuite timed out.