fix(check): retry system Chrome after managed launch crash - #3701
Merged
Conversation
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Windows STATUS_STACK_BUFFER_OVERRUN recovery with system Chrome fallback is well scoped — crash code matching, proper error enrichment, and all three paths (retry success, no system Chrome, unrelated error) tested. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
checkand the other shared screenshot diagnostics now recover when the managed Windows chrome-headless-shell exits withSTATUS_STACK_BUFFER_OVERRUN. They retry once with an installed system Chrome, or return actionableHYPERFRAMES_BROWSER_PATHguidance when no fallback exists.Why
HyperFrames already recognizes exit code
3221225595and explains the system-Chrome workaround forrender, but the shared page-open path closed and rethrew the raw launch error. A valid composition therefore failed before navigation even though Chrome was available on the host.How
The screenshot page-open boundary reuses the existing Windows crash detector, retries only managed cache/download sources, and recomputes browser GPU policy for the fallback executable. System Chrome discovery now checks the standard machine-wide and per-user Windows install locations before
where, so Chrome need not be onPATH. Explicit/system browser choices and unrelated launch failures retain their existing behavior.Test plan
Unit tests added/updated
Manual testing performed
Documentation updated (not applicable)
Five browser-manager, page-open, crash-detector, and check suites: 96 tests passed
Changed-file oxlint, oxfmt, and diff checks passed
The Windows binary crash was injected on this Linux host rather than rerun on Windows. CLI-wide typecheck remains unavailable because optional AWS/GCP dependencies are absent and unrelated Studio/schema errors predate this change; it reported no changed-path error.