test(cli): track exact chrome pids after kill -9, pipe vs port

Author: miguel-heygen

.github/checkfast/orphans.mjs

@@ -25,29 +25,37 @@ const serving = (dir) => existsSync(join(dir, ".hyperframes")) && readdirSync(jo
 async function waitFor(cond, ms) { const end = Date.now() + ms; while (!cond()) { if (Date.now() > end) return false; await sleep(200); } return true; }
 const env = { ...process.env, HYPERFRAMES_NO_TELEMETRY: "1", CI: "" };
 delete env.CI;
+const alive = (pid) => { try { process.kill(pid, 0); return true; } catch { return false; } };
 async function scenario(kind) {
   const dir = hangProject();
-  const base = count();
+  const base = new Set(pids());
+  const mine = () => pids().filter((p) => !base.has(p));
   let victim;
   if (kind === "warm") {
     victim = spawn(process.execPath, ["dist/warmCheck.js", "60000", dir, "--json", "--samples=1", "--no-browser-gpu"], { cwd: cli, env, stdio: "ignore" });
-    await waitFor(() => count() > base, 30_000);
+    await waitFor(() => mine().length > 0, 30_000);
     await sleep(2000);
     const client = spawn(process.execPath, ["bin/hyperframes.mjs", "check", dir, "--json", "--samples=1", "--no-browser-gpu"], { cwd: cli, env, stdio: ["ignore", "pipe", "pipe"] });
     client.stdout.on("data", () => {}); client.stderr.on("data", () => {});
+    scenario.client = client;
   } else {
     victim = spawn(process.execPath, ["bin/hyperframes.mjs", "check", dir, "--json", "--samples=1", "--no-browser-gpu"], { cwd: cli, env: { ...env, CI: "1" }, stdio: ["ignore", "pipe", "pipe"] });
     victim.stdout.on("data", () => {}); victim.stderr.on("data", () => {});
   }
   const busy = await waitFor(() => serving(dir), 60_000);
   await sleep(3000);
-  const during = count();
+  const during = mine();
   process.kill(victim.pid, "SIGKILL");
-  await sleep(5000);
-  const after = count();
-  console.log(`ORPHANS ${process.platform} ${kind}: busy=${busy} baseline=${base} during=${during} 5s-after-kill=${after} ${after > base ? "SURVIVORS" : "clean"}`);
-  // clean up whatever survived so the next scenario starts from zero
-  for (const pid of pids()) { try { process.kill(pid, "SIGKILL"); } catch {} }
+  const report = [];
+  for (const at of [5, 15, 30]) {
+    await sleep(at === 5 ? 5000 : at === 15 ? 10000 : 15000);
+    report.push(`${at}s:${during.filter(alive).length}`);
+  }
+  const left = during.filter(alive).length;
+  console.log(`ORPHANS ${process.platform} ${kind}: busy=${busy} tracked=${during.length} survivors ${report.join(" ")} ${left ? "SURVIVORS" : "clean"}`);
+  for (const pid of [...pids().filter((p) => !base.has(p)), scenario.client?.pid].filter(Boolean)) { try { process.kill(pid, "SIGKILL"); } catch {} }
+  scenario.client = undefined;
   await sleep(2000);
 }
-for (const kind of ["cold", "warm", "cold", "warm"]) await scenario(kind);
+const kinds = process.argv[2] === "port" ? ["cold-port", "cold-port"] : ["cold", "warm", "cold", "warm"];
+for (const kind of kinds) await scenario(kind);

.github/checkfast/winlaunch.sh

@@ -1,3 +1,6 @@
 set -u
 if [ "$RUNNER_OS" = "Windows" ]; then node --import tsx packages/cli/scripts/prepare-process-test-browser.mjs; export HYPERFRAMES_BROWSER_PATH=$(grep HYPERFRAMES_BROWSER_PATH "$GITHUB_ENV" | tail -1 | cut -d= -f2-); else node packages/cli/bin/hyperframes.mjs browser ensure >/dev/null 2>&1; fi
 node .github/checkfast/orphans.mjs
+sed -i.bak 's/puppeteer.launch({ ...options, pipe: true,/puppeteer.launch({ ...options, pipe: false,/' packages/cli/src/browser/launch.ts
+(cd packages/cli && bun run build >/dev/null 2>&1; echo "port build=$?")
+node .github/checkfast/orphans.mjs port