test(cli): count chrome survivors after kill -9 of warm and cold checks

Author: miguel-heygen

.github/checkfast/orphans.mjs

@@ -0,0 +1,53 @@
+// Kill -9 the warm process (or a cold check) mid busy-loop; count every chrome-headless-shell process 5 s later.
+import { execSync, spawn } from "node:child_process";
+import { existsSync, mkdirSync, mkdtempSync, readdirSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+const win = process.platform === "win32";
+const cli = join(process.cwd(), "packages/cli");
+const sleep = (ms) => new Promise((r) => setTimeout(r, ms));
+function pids() {
+  try {
+    return win
+      ? execSync('tasklist /FI "IMAGENAME eq chrome-headless-shell.exe" /NH /FO CSV', { encoding: "utf8" }).split("\n").filter((l) => /chrome-headless-shell/i.test(l)).map((l) => Number(l.split(",")[1]?.replace(/"/g, "")))
+      : execSync("pgrep -f chrome-headless-shell || true", { encoding: "utf8" }).split("\n").filter(Boolean).map(Number);
+  } catch { return []; }
+}
+const count = () => pids().length;
+function hangProject() {
+  const dir = mkdtempSync(join(tmpdir(), "hf-orphan-"));
+  mkdirSync(join(dir, "compositions"));
+  writeFileSync(join(dir, "index.html"), `<!doctype html><html><body><div data-composition-id="main" data-width="320" data-height="180" data-duration="1"><div data-composition-id="hang" data-composition-src="compositions/hang.html" data-start="0" data-duration="1"></div></div><script>window.__timelines={main:{duration:()=>1,seek:()=>{},pause:()=>{}}};</script></body></html>`);
+  writeFileSync(join(dir, "compositions/hang.html"), `<template id="hang"><div data-composition-id="hang"><div id="box" style="width:1px;height:1px"></div><script>const el=document.getElementById("box");while(el.offsetWidth<2){el.style.height="1px";}</script></div></template>`);
+  return dir;
+}
+const serving = (dir) => existsSync(join(dir, ".hyperframes")) && readdirSync(join(dir, ".hyperframes")).length > 0;
+async function waitFor(cond, ms) { const end = Date.now() + ms; while (!cond()) { if (Date.now() > end) return false; await sleep(200); } return true; }
+const env = { ...process.env, HYPERFRAMES_NO_TELEMETRY: "1", CI: "" };
+delete env.CI;
+async function scenario(kind) {
+  const dir = hangProject();
+  const base = count();
+  let victim;
+  if (kind === "warm") {
+    victim = spawn(process.execPath, ["dist/warmCheck.js", "60000", dir, "--json", "--samples=1", "--no-browser-gpu"], { cwd: cli, env, stdio: "ignore" });
+    await waitFor(() => count() > base, 30_000);
+    await sleep(2000);
+    const client = spawn(process.execPath, ["bin/hyperframes.mjs", "check", dir, "--json", "--samples=1", "--no-browser-gpu"], { cwd: cli, env, stdio: ["ignore", "pipe", "pipe"] });
+    client.stdout.on("data", () => {}); client.stderr.on("data", () => {});
+  } else {
+    victim = spawn(process.execPath, ["bin/hyperframes.mjs", "check", dir, "--json", "--samples=1", "--no-browser-gpu"], { cwd: cli, env: { ...env, CI: "1" }, stdio: ["ignore", "pipe", "pipe"] });
+    victim.stdout.on("data", () => {}); victim.stderr.on("data", () => {});
+  }
+  const busy = await waitFor(() => serving(dir), 60_000);
+  await sleep(3000);
+  const during = count();
+  process.kill(victim.pid, "SIGKILL");
+  await sleep(5000);
+  const after = count();
+  console.log(`ORPHANS ${process.platform} ${kind}: busy=${busy} baseline=${base} during=${during} 5s-after-kill=${after} ${after > base ? "SURVIVORS" : "clean"}`);
+  // clean up whatever survived so the next scenario starts from zero
+  for (const pid of pids()) { try { process.kill(pid, "SIGKILL"); } catch {} }
+  await sleep(2000);
+}
+for (const kind of ["cold", "warm", "cold", "warm"]) await scenario(kind);

.github/checkfast/winlaunch.sh

@@ -1,10 +1,3 @@
 set -u
-node --import tsx packages/cli/scripts/prepare-process-test-browser.mjs
-export HYPERFRAMES_BROWSER_PATH=$(grep HYPERFRAMES_BROWSER_PATH "$GITHUB_ENV" | tail -1 | cut -d= -f2-)
-cd packages/cli
-chromes() { echo "CHROME $1: $(tasklist //FI "IMAGENAME eq chrome-headless-shell.exe" //NH 2>/dev/null | grep -ci chrome-headless) headless-shell procs; $(powershell -NoProfile -Command "(Get-Process chrome-headless-shell -ErrorAction SilentlyContinue | Measure-Object -Property CPU -Sum).Sum") cpu-s"; }
-chromes before
-npx vitest run src/warmCheck.process.test.ts --maxWorkers=1 2>&1 | sed 's/\x1b\[[0-9;]*m//g' | grep -E "✓|×|Tests " | sed 's/^/WARM /'
-chromes after-warm; sleep 20; chromes after-warm+20s
-npx vitest run src/warmCheck.process.test.ts src/utils/checkDeadline.process.test.ts --maxWorkers=2 2>&1 | sed 's/\x1b\[[0-9;]*m//g' | grep -E "✓|×|Tests " | sed 's/^/BOTH /'
-chromes after-both
+if [ "$RUNNER_OS" = "Windows" ]; then node --import tsx packages/cli/scripts/prepare-process-test-browser.mjs; export HYPERFRAMES_BROWSER_PATH=$(grep HYPERFRAMES_BROWSER_PATH "$GITHUB_ENV" | tail -1 | cut -d= -f2-); else node packages/cli/bin/hyperframes.mjs browser ensure >/dev/null 2>&1; fi
+node .github/checkfast/orphans.mjs

.github/workflows/checkfast-measure.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [windows-latest]
+        os: [ubuntu-latest, macos-latest, windows-latest]
     env:
       HYPERFRAMES_NO_TELEMETRY: "1"
       DO_NOT_TRACK: "1"