Repository navigation
Isolate concurrent OTP builds - #326
Merged
Merged
Conversation
Use each build's image ID and a Docker-assigned container ID so overlapping OTP branch builds don't remove each other's containers. Clean up on failure and interruption, and download the queued commit SHA.
Check that the script uses the image and container IDs returned by Docker. Remove the fake image retagging and container lifecycle simulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTP branch builds for different SHAs can overlap on one agent and reuse the same container name, causing a newer build to kill the older one with exit 137. Use the build's image ID and a new container ID for each invocation, clean up on failure or interruption, and download the queued SHA instead of the moving ref.
Add seven script regressions for overlapping builds, cleanup, and commit pinning. Local validation passed 496 tests with one existing GNU timeout test excluded because GNU timeout isn't installed, plus compiler, formatter, and Docker fixture checks. Full OTP compilation wasn't run.
Publication ordering remains unresolved: an older branch build finishing last can still overwrite a newer artifact and its metadata.