Repository navigation
Track final HTTP outcomes and tolerate Docker Hub failures - #304
Merged
Merged
Conversation
ericmj
marked this pull request as ready for review
September 5, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route Docker Hub tag lookups through the shared rate limiter. When retries are exhausted or a response contains invalid JSON, return
:unreadableso manifest generation preserves the existing image and the next checker run can retry.Add
Bob.HTTP.track_request/3and the genericbob_prom_ex_outbound_http_request_final_totalcounter, labeled by host, method, and final status. Docker Hub, GitHub, Fastly, and Bob master requests record one outcome after their complete retry operation. Docker Hub's outer 429 retry loop is included. The existing Finch counters retain individual attempts, and telemetry excludes URLs, credentials, headers, and response bodies.Deploy the new metric before https://github.com/hexpm/hexpm-ops/pull/317, which selects Docker Hub through the host label and configures its tolerance in the alert rule.
Validated locally on Elixir 1.20.3/OTP 29 with the formatter, compilation with warnings as errors, and the full test suite: 453 tests passed, with one GNU
timeouttest excluded because the binary isn't installed. Regression coverage includes final outcomes after retry recovery and exhaustion, metric export, manifest preservation, and re-enqueueing skipped manifests.