Repository navigation
Start PromEx before the repo - #277
Merged
Merged
Conversation
The Ecto plugin builds its repo, pool size and timeout metrics from the telemetry event a repo emits once, as it starts. PromEx started after the repo, missed it, and never exported bob_prom_ex_ecto_repo_init_status_info, which is where the Ecto dashboard's repo dropdown gets its options. With no option to select, every panel on that dashboard filtered on an empty repo and rendered nothing.
Process.exit only sends the signal. The runner holds its registered name
until it has actually terminated, so the next test's start_link could race
it and lose with {:error, {:already_started, pid}}. CI hit this on one of
two runs of the same commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bob's Ecto dashboard has been empty since it went up. The repo dropdown reads its options from
bob_prom_ex_ecto_repo_init_status_info, which PromEx's Ecto plugin builds from the telemetry event a repo emits once, as it starts. PromEx was supervised after the repo, so it missed the event and never exported the metric. With no option to select, every panel filtered on an empty repo and rendered nothing.hexpm and hexpm_billing already start PromEx first, which is why their Ecto dashboards work.