Skip to content

Report outbound HTTP calls and which revision is running - #276

Merged
ericmj merged 1 commit into
mainfrom
outbound-http-metrics
Jul 27, 2026
Merged

ericmj merged 1 commit into
mainfrom
outbound-http-metrics

Conversation

@ericmj

@ericmj ericmj commented Jul 27, 2026

Copy link
Copy Markdown
Member

Two gaps in what the applications report about themselves.

Outbound HTTP

Nothing described the calls this application makes, so a slow dependency was indistinguishable from slow code. Everything outbound goes through Finch, whether reached directly or through a library layered on top of it, so a single plugin attached to Finch covers all of them rather than each library needing its own.

Reports request duration and count by host, method and status, exceptions, time spent waiting for a connection from the pool, and connection setup time. Tagged by host rather than URL so the series stay bounded by the handful of services we talk to. Failed requests are labelled with the error rather than dropped, so a dependency that stops responding is visible rather than merely absent.

Git SHA and author

The Application dashboard panels for these read Git SHA not available, because PromEx takes them from the environment and nothing set it. They are now build arguments.

Declared in the final stage so a new commit does not invalidate the build cache for everything above it, and given defaults because PromEx uses System.fetch_env, which treats an empty variable as present — without a default a build made without the arguments would label the metric with a blank rather than saying it is unknown. Verified by building both ways.

Nothing described the calls this application makes, so a slow dependency was
indistinguishable from slow code. Everything outbound goes through Finch,
whether reached directly or through a library layered on it, so one plugin
covers all of them: request duration and count by host, method and status,
exceptions, time spent waiting for a pool connection, and connection setup
time. Requests are tagged by host rather than URL to keep the series bounded.

The Git SHA and author panels were empty because PromEx reads them from the
environment and nothing set it. They are now build arguments, declared in the
final stage so a new commit does not invalidate the cache above it, and given
defaults because PromEx treats an empty variable as present and would label the
metric with a blank instead of saying it is unknown.
@ericmj
ericmj merged commit cd2e545 into main Jul 27, 2026
4 checks passed
@ericmj
ericmj deleted the outbound-http-metrics branch July 27, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant