Support building on Mac with Apple Xcode#12
Open
Motti-Shneor wants to merge 1 commit intohessu:masterfrom
Open
Support building on Mac with Apple Xcode#12Motti-Shneor wants to merge 1 commit intohessu:masterfrom
Motti-Shneor wants to merge 1 commit intohessu:masterfrom
Conversation
…ple developer/app-store certificates) bchunk for Mac. 1. Supports 64bit architecture 2. Supports Intel X86, X64, Apple M1 architectures - and will build a dual "fat" binary with intel x64 + Apple M1 support 3. Forced to rename one var name in bchunk.c to avoid symbol/name clash with /usr/include/curses.h
hessu
requested changes
Oct 10, 2021
Owner
hessu
left a comment
hessu
left a comment
There was a problem hiding this comment.
Sorry for the late review. In principle this looks good, just one little naming thing I'd like to see adjusted. Thanks!
| ENABLE_HARDENED_RUNTIME = YES; | ||
| GCC_WARN_ABOUT_MISSING_FIELD_INITIALIZERS = YES; | ||
| GCC_WARN_PEDANTIC = YES; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.Tchelet.bchunk; |
Owner
There was a problem hiding this comment.
Maybe just "com.bchunk", I guess Tchelet refers to yourself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Apple Xcode project to build (and optionally code-sign chunk using Apple developer/app-store certificates)
3 Supports MacOS 10.9 and later (virtually any MacOS on the market today)
I was forced to rename one var name in bchunk.c to avoid symbol/name clash with /usr/include/curses.h