Repository navigation
Add read-only recent and get CLI commands - #85
Conversation
Reviewer's GuideThis PR adds server-backed, read-only Sequence diagram for read-only CLI browsingsequenceDiagram
actor User
participant CLI as fidelis CLI
participant Server as fidelis-server
alt recent
User->>CLI: recent --limit --kind --since [--raw]
CLI->>Server: POST /recent
Server-->>CLI: records or error
else get
User->>CLI: get RECORD_ID [--raw]
CLI->>Server: POST /get
Server-->>CLI: record and correction chain or error
end
alt service error or unknown record
CLI-->>User: explicit error and nonzero exit
else raw output
CLI-->>User: JSON payload
else human-readable output
CLI-->>User: formatted record metadata
end
Flow diagram for bounded recent commandflowchart LR
A[Parse recent options] --> B{limit from 1 to 50}
B -->|invalid| C[Argument error]
B -->|valid| D[POST /recent]
D --> E{error in response}
E -->|yes| F[Print error and exit nonzero]
E -->|no| G{--raw}
G -->|yes| H[Print JSON payload]
G -->|no| I[Print records with filters and metadata]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
roli-lpci
left a comment
roli-lpci
left a comment
There was a problem hiding this comment.
Thanks for adding the bounded recent/get browsing commands and coverage. I reviewed the full diff at 9a361da and the unchanged CI workflow. The fork workflow is suitable to run, but the shared HTTP error handling introduces the regression below, which needs fixing before merge. Please add coverage for an existing read command receiving an HTTP error as well as the new browsing commands.
Reviewed by a Hermes Labs agent at the maintainer’s direction.
d293096 to
0fd1459
Compare
roli-lpci
left a comment
roli-lpci
left a comment
There was a problem hiding this comment.
Thanks @GaoYqqqq — the opt-in structured error handling addresses the requested regression. I reviewed the complete four-file diff at 0fd1459 and independently checked HTTP 503 behavior for query, recall, recent, and get in both normal and raw modes: all eight checks exit 1, existing commands do not report an empty successful result, and the new raw modes retain the structured error payload. The query regression tests cover normal/raw modes. No further source changes are requested by this review.
I approved the new fork CI run; the full matrix/build checks still need to pass before merge acceptance.
Reviewed by a Hermes Labs agent at the maintainer’s direction.
|
Thanks @GaoYqqqq — merged as 47b88a2, closing #83. Your bounded read-only CLI commands meet the issue criteria, and the opt-in structured error handling preserves failures for existing commands. All ten Python/OS CI matrix jobs and the package build passed on 0fd1459. Matching local Gate fast and technical review receipts passed with no findings; the installed Gate used its validated hermes-pr-review fallback after CodeRabbit, and an independent steward accepted the exact head before the guarded merge. Reviewed by a Hermes Labs agent at the maintainer’s direction. |
Summary
fidelis recentwith a bounded limit, existing kind/since filters, and raw JSON outputfidelis get RECORD_IDwith human-readable temporal and correction-chain metadataTesting
python -m pytest tests/test_cli_browse.py tests/test_mcp_surface_v2.py tests/test_write_fallback_contract.py -q— 74 passedpython -m ruff check src/ tests/git diff --checkCloses #83
Summary by Sourcery
Add read-only CLI browsing for recent memories and individual records with correction metadata, raw output, bounded filtering, and explicit error handling.
New Features:
recentandgetCLI commands for browsing records, filtering recent results, and retrieving correction chains.Bug Fixes:
Enhancements:
Documentation:
Tests: