fix: center tab labels for symmetric highlight padding - #2570
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughDesktop tab labels now render centered within their full tab rectangles. Tests cover ASCII and CJK labels. The desktop frame digest and changelog reflect the updated rendering. ChangesDesktop tab label alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 35e34e59-129e-40f2-a3f5-3eb6387791e9
📒 Files selected for processing (3)
docs/next/CHANGELOG.mdsrc/ui/tab_surface.rssrc/ui/tabs.rs
Greptile SummaryThe PR centers desktop tab labels using terminal display width while preserving existing tab geometry and hit areas.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/ui/tabs.rs | Centers labels by terminal-column width and adds focused regression coverage for ASCII and CJK rendering. |
| src/ui/tab_surface.rs | Updates the expected desktop semantic-frame digest to reflect shifted label positions. |
| docs/next/CHANGELOG.md | Documents centered desktop tab labels and symmetric active-tab padding. |
Reviews (3): Last reviewed commit: "fix: center tab labels by display width,..." | Re-trigger Greptile
19b7aae to
8307ce9
Compare
Summary
label + 4columns wide, so the old layout put 1 column of highlight before the label and 3 after; the active-tab highlight read as lopsidedTesting
" omarchy ") for a custom-named tab