Aligning implementation/specification error codes - phase 3/5 - #1989
Merged
Merged
Conversation
Roman-Manevich
changed the title
Roman-Manevich
marked this pull request as ready for review
September 4, 2026 11:42
Roman-Manevich
changed the base branch from
master
to
asl-error-codes-phase-2
September 4, 2026 11:42
Roman-Manevich
force-pushed
the
asl-error-codes-phase-3
branch
2 times, most recently
from
September 4, 2026 14:14
71be2cd to
79d0133
Compare
hrutvik
reviewed
Sep 4, 2026
Roman-Manevich
force-pushed
the
asl-error-codes-phase-3
branch
from
September 4, 2026 19:03
79d0133 to
0077e04
Compare
| else | ||
| fatal_from e1 env (Error.MismatchType (B.debug_value v, [ t.desc ]))) | ||
| fatal_from e1 env | ||
| (Error.ATCFailure (C.error_handling_time, B.debug_value v, t.desc))) |
Collaborator
There was a problem hiding this comment.
Maybe we should have something a bit more flexible than debug_value, ideally a formatter
Probably not for this PR.
Roman-Manevich
force-pushed
the
asl-error-codes-phase-3
branch
from
September 7, 2026 09:12
0077e04 to
3ca79fc
Compare
Roman-Manevich
force-pushed
the
asl-error-codes-phase-3
branch
from
September 7, 2026 21:27
3ca79fc to
3c1daa3
Compare
HadrienRenaud
approved these changes
Sep 8, 2026
HadrienRenaud
left a comment
HadrienRenaud
left a comment
Collaborator
There was a problem hiding this comment.
This looks ok to me, but please double check with Hrutvik that he's happy with it
hrutvik
approved these changes
Sep 8, 2026
hrutvik
left a comment
hrutvik
left a comment
Collaborator
There was a problem hiding this comment.
I think just a few minor bits to clear up before merging:
- Hadrien's comment on
providedvs.actual - Hadrien's comment on
BadAritydocstring
And then we can continue offline discussion on BadArity
Roman-Manevich
force-pushed
the
asl-error-codes-phase-3
branch
from
September 8, 2026 15:30
3c1daa3 to
4d5127a
Compare
Roman-Manevich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish lexical and parse failures
Lexer-detected invalid symbols now use
UnknownSymboland reportBE_LE, preserving suggested replacements, while the remainingCannotParseerrors reportBE_PE.Classify global-initialization exceptions
Exceptions escaping global initialization now report
DE_UE, andbuild_genvinasl.specconverts the corresponding throwing result toDynamicError(DE_UE).Classify asserted-type-conversion failures
Failed asserted type conversions now use
ATCFailure, reportingDE_TAFduring dynamic evaluation andTE_SEFduring static evaluation as specified byasl.spec.Classify repeated tuple-field writes
Repeated fields in tuple assignments now report
TE_IAD, matching the specification's use ofcheck_no_duplicatesrather than the rework PR's disputedBE_PEmapping.Distinguish call and tuple arity failures
Static call arity failures now report
TE_BCthroughBadCallArity, while tuple arity failures reportTE_UTthroughBadTupleArity; unchecked runtime arity failures remain uncoded.