Disabling formatting of the block of code#438
Open
Lev135 wants to merge 2 commits intohaskell:mainfrom
Open
Conversation
jaspervdj
reviewed
Jan 2, 2023
Member
jaspervdj
left a comment
There was a problem hiding this comment.
I like the approach of doing this in Editor — I will look at the implementation in more detail once I’m back from holidays.
Contributor
Author
|
@jaspervdj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is one of the possible solutions to this issue. It's very straightforward: just collecting all edits and then filtering them and applying only those, that doesn't intersect with the block of code between
{- stylish_disable -}and{- stylish_enable -}.Filtering is applied by rows only, so, in this sample
data will not be reformated. In the first my iplementation columns also were taken into account, but this made the code much more havier and didn't make much sense for me: such constructions as in example above seems too artificial.
Anyway this issue was discussed several times here (#409 is the latest one). So it seems to be very helpful feature, not for me only. So it would be nice to discuss and resolve it one way or another