You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Regarding containers.h , I searched for values defined in containers.h , such as DEFINE_PATTERN_SYNONYMS , and removed the containers.h include from files where these values were absent. (LLMs were not used)
Regarding C++ pragmas, I first checked each file for the presence of #ifdef and similar directives. (No LLM was used.) Afterward, out of concern, I asked the LLM if there were any places where C++ pragma declarations might have been accidentally left in.
Additionally, when drafting the PR description, I used an LLM to translate from Japanese to English.
If there are any errors or omissions, please provide guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removed unnecessary CPP and C header includes.
Correction details
C header removal
The following modules use values defined in
containers.h:Removed
#include "containers.h"from all other modules.CPP removal
Removed CPP language pragmas from files that do not use CPP directives.
Testing
cabal build containerssucceedscabal test containers-testspasses all testscabal bench containers-testspasses all benchmarksWhile the changes are straightforward, they affect a wide range of files, so careful review is requested.
Fixes #968