Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
681db30
Use zod schemas for validating route data so that their types are ver…
correct-horse-battery-bench Aug 5, 2026
befcba7
Validate query params with zod schemas
correct-horse-battery-bench Aug 5, 2026
da066a7
Use const object enums wherever possible
correct-horse-battery-bench Aug 5, 2026
1bad301
Cleanup before pr
correct-horse-battery-bench Aug 5, 2026
db495e1
Remove unused directives and the DirectivesModule wiring
correct-horse-battery-bench Aug 5, 2026
3e968ac
Remove unused screen size detector component and service
correct-horse-battery-bench Aug 5, 2026
a1079a9
Remove unused loading spinner components and LoadingService
correct-horse-battery-bench Aug 5, 2026
9a153f4
Remove unused grid container components
correct-horse-battery-bench Aug 5, 2026
89f79b8
Remove unused task visual graph component
correct-horse-battery-bench Aug 5, 2026
ac20ed4
Remove unused filter textbox, password match and scroll-to-top compon…
correct-horse-battery-bench Aug 5, 2026
0c0232a
Remove unused agent status modal component
correct-horse-battery-bench Aug 5, 2026
2ec5742
Remove unused idle, cookie storage, property resolver and supertask c…
correct-horse-battery-bench Aug 5, 2026
5fcf653
Remove unused breadcrumb component and route breadcrumb data
correct-horse-battery-bench Aug 5, 2026
4c21310
Remove unreachable routes and route data no longer read by any component
correct-horse-battery-bench Aug 5, 2026
f8e9f98
Remove unused form definitions from MetadataService
correct-horse-battery-bench Aug 5, 2026
317dfcf
Remove unused models, schemas and helper types
correct-horse-battery-bench Aug 5, 2026
b6ece9e
Remove unused constants, type declarations and empty files
correct-horse-battery-bench Aug 5, 2026
b3fdeef
Remove unused utility functions
correct-horse-battery-bench Aug 5, 2026
9a4034d
Remove unused test element helpers
correct-horse-battery-bench Aug 5, 2026
d9afb55
Merge branch 'master' into 2241-enhancement-remove-dead-code
correct-horse-battery-bench Aug 6, 2026
f9b5864
Remove stale breadcrumb route data from formconfig spec
correct-horse-battery-bench Aug 6, 2026
9204f28
Remove unused spec helpers
correct-horse-battery-bench Aug 6, 2026
cb7e7d8
Run prettier and linter
correct-horse-battery-bench Aug 6, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions src/app/account/account-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ import { NgModule } from '@angular/core';
import { RouterModule } from '@angular/router';

import { MyRoute } from '@models/routes.model';
import { FormRouteType } from '@models/routes.schema';

import { SERV } from '@services/main.config';

import { AccountComponent } from '@src/app/account/account.component';
import { ApiKeyDetailComponent } from '@src/app/account/api-keys/api-key-detail/api-key-detail.component';
Expand All @@ -23,75 +20,41 @@ const routes: MyRoute[] = [
{
path: '',
component: AccountComponent,
data: {
kind: 'account',
breadcrumb: ''
},
canActivate: [IsAuth]
},
{
path: 'acc-settings',
component: AccountSettingsComponent,
data: {
kind: 'acc-settings',
breadcrumb: 'Account Settings'
},
canActivate: [IsAuth]
},
{
path: 'ui-settings',
component: UiSettingsComponent,
data: {
kind: 'uisettings',
type: FormRouteType.Edit,
serviceConfig: SERV.CONFIGS,
breadcrumb: 'UI Settings'
},
canActivate: [IsAuth]
},
{
path: 'notifications',
component: NotificationsComponent,
data: {
kind: 'notifications',
breadcrumb: 'Notifications'
},
canActivate: [IsAuth]
},
{
path: 'notifications/new-notification',
component: NewNotificationComponent,
data: {
kind: 'new-notifications',
breadcrumb: 'New Notification'
},
canActivate: [IsAuth]
},
{
path: 'api-keys',
component: ApiKeysComponent,
data: {
kind: 'api-keys',
breadcrumb: 'API Keys'
},
canActivate: [IsAuth]
},
{
path: 'api-keys/new',
component: NewApiKeyComponent,
data: {
kind: 'new-api-key',
breadcrumb: 'New API Key'
},
canActivate: [IsAuth]
},
{
path: 'api-keys/:id',
component: ApiKeyDetailComponent,
data: {
kind: 'api-key-detail',
breadcrumb: 'API Key Details'
},
canActivate: [IsAuth]
}
]
Expand Down
2 changes: 0 additions & 2 deletions src/app/account/account.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import { NotificationsComponent } from '@src/app/account/notifications/notificat
import { AccountSettingsComponent } from '@src/app/account/settings/acc-settings/acc-settings.component';
import { UiSettingsComponent } from '@src/app/account/settings/ui-settings/ui-settings.component';
import { ComponentsModule } from '@src/app/shared/components.module';
import { DirectivesModule } from '@src/app/shared/directives.module';
import { CoreFormsModule } from '@src/app/shared/forms.module';
import { PipesModule } from '@src/app/shared/pipes.module';

Expand All @@ -51,7 +50,6 @@ import { PipesModule } from '@src/app/shared/pipes.module';
ComponentsModule,
CoreFormsModule,
CoreComponentsModule,
DirectivesModule,
RouterModule,
CommonModule,
PipesModule,
Expand Down
2 changes: 0 additions & 2 deletions src/app/account/settings/acc-settings/acc-settings.schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,3 @@ export const changeOwnPasswordResponseSchema = z.object({
'Change password': z.string()
})
});

export type ChangeOwnPasswordResponse = z.infer<typeof changeOwnPasswordResponseSchema>;

This file was deleted.

This file was deleted.

11 changes: 1 addition & 10 deletions src/app/agents/agent.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,33 +7,24 @@ import { RouterModule } from '@angular/router';

import { CoreComponentsModule } from '@components/core-components.module';

import { AgentStatusModalComponent } from '@src/app/agents/agent-status/agent-status-modal/agent-status-modal.component';
import { AgentStatusComponent } from '@src/app/agents/agent-status/agent-status.component';
import { AgentsRoutingModule } from '@src/app/agents/agents-routing.module';
import { EditAgentComponent } from '@src/app/agents/edit-agent/edit-agent.component';
import { NewAgentComponent } from '@src/app/agents/new-agent/new-agent.component';
import { ShowAgentsComponent } from '@src/app/agents/show-agents/show-agents.component';
import { ComponentsModule } from '@src/app/shared/components.module';
import { DirectivesModule } from '@src/app/shared/directives.module';
import { CoreFormsModule } from '@src/app/shared/forms.module';
import { AgentStatGraphComponent } from '@src/app/shared/graphs/echarts/agent-stat-graph/agent-stat-graph.component';
import { PipesModule } from '@src/app/shared/pipes.module';

@NgModule({
declarations: [
AgentStatusModalComponent,
AgentStatusComponent,
ShowAgentsComponent,
EditAgentComponent,
NewAgentComponent
],
declarations: [AgentStatusComponent, ShowAgentsComponent, EditAgentComponent, NewAgentComponent],
imports: [
CoreComponentsModule,
CoreFormsModule,
FontAwesomeModule,
ReactiveFormsModule,
AgentsRoutingModule,
DirectivesModule,
ComponentsModule,
CoreFormsModule,
CommonModule,
Expand Down
8 changes: 0 additions & 8 deletions src/app/agents/agents-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ const routes: MyRoute[] = [
path: 'agent-status',
component: AgentStatusComponent,
data: {
kind: 'agent-status',
breadcrumb: 'Agent Status',
roleServiceClass: roleServiceClass,
roleName: 'readStat'
},
Expand All @@ -34,8 +32,6 @@ const routes: MyRoute[] = [
path: 'new-agent',
component: NewAgentComponent,
data: {
kind: 'new-agent',
breadcrumb: 'New Agent',
roleServiceClass: roleServiceClass,
roleName: 'create'
},
Expand All @@ -45,8 +41,6 @@ const routes: MyRoute[] = [
path: 'show-agents',
component: ShowAgentsComponent,
data: {
kind: 'show-agents',
breadcrumb: 'Show Agent',
roleServiceClass: roleServiceClass,
roleName: 'read'
},
Expand All @@ -56,8 +50,6 @@ const routes: MyRoute[] = [
path: 'show-agents/:id/edit',
component: EditAgentComponent,
data: {
kind: 'edit-agent',
breadcrumb: 'Edit Agent',
roleServiceClass: roleServiceClass,
roleName: 'read'
},
Expand Down
4 changes: 1 addition & 3 deletions src/app/agents/edit-agent/edit-agent.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import { EditAgentComponent } from '@src/app/agents/edit-agent/edit-agent.compon
import { AgentOS } from '@src/app/core/_constants/agentsc.config';
import { ButtonsModule } from '@src/app/shared/buttons/buttons.module';
import { ComponentsModule } from '@src/app/shared/components.module';
import { DirectivesModule } from '@src/app/shared/directives.module';
import { CoreFormsModule } from '@src/app/shared/forms.module';
import { InputModule } from '@src/app/shared/input/input.module';
import { PageTitleModule } from '@src/app/shared/page-headers/page-title.module';
Expand Down Expand Up @@ -216,8 +215,7 @@ describe('EditAgentComponent', () => {
InputModule,
TableModule,
ComponentsModule,
CoreFormsModule,
DirectivesModule
CoreFormsModule
],
providers: [
{ provide: AlertService, useValue: alertServiceSpy },
Expand Down
15 changes: 1 addition & 14 deletions src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,29 +35,16 @@ import { ErrorPageComponent } from '@src/app/layout/error-page/error-page.compon
import { FooterComponent } from '@src/app/layout/footer/footer.component';
import { LayoutHeaderModule } from '@src/app/layout/header/header.module';
import { PageNotFoundComponent } from '@src/app/layout/page-not-found/page-not-found.component';
import { ScreenSizeDetectorComponent } from '@src/app/layout/screen-size-detector/screen-size-detector.component';
import { BreadcrumbComponent } from '@src/app/shared/breadcrumb/breadcrumb.component';
import { ComponentsModule } from '@src/app/shared/components.module';
import { DirectivesModule } from '@src/app/shared/directives.module';
import { PipesModule } from '@src/app/shared/pipes.module';
import { ScrollYTopComponent } from '@src/app/shared/scrollytop/scrollytop.component';

@NgModule({
declarations: [
ScreenSizeDetectorComponent,
PageNotFoundComponent,
ScrollYTopComponent,
BreadcrumbComponent,
ErrorPageComponent,
FooterComponent,
AppComponent
],
declarations: [PageNotFoundComponent, ErrorPageComponent, FooterComponent, AppComponent],
bootstrap: [AppComponent],
imports: [
BrowserAnimationsModule,
ReactiveFormsModule,
FontAwesomeModule,
DirectivesModule,
ComponentsModule,
BrowserModule,
CommonModule,
Expand Down
Loading
Loading