Implement adaptive chunk sizes / adaptive speed benchmark results - #2427
Draft
mr-creditcard wants to merge 12 commits into
Draft
Implement adaptive chunk sizes / adaptive speed benchmark results#2427mr-creditcard wants to merge 12 commits into
mr-creditcard wants to merge 12 commits into
Conversation
…ken and chunk target time
This fix should not be part of this merge request - my bad
…ems - to-be-removed.
Addresses requirement mentioned in hashtopolis#729 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the work done by @0xVavaldi in #729. I have cherry-picked their commits and added my own on top in an attempt to keep attribution in place. It addresses issues #551 & #2295.
The aforementioned PR has a number of requirements set by @s3inlc in the comments which have remained unaddressed thusfar, this PR aims to implement these. The changes include:
APISendProgress.php's switch statement overDHashcatStatus. In commit dbd4b32 this logic is moved toTaskUtils.phpinstead and is called with a function call.At the time of writing this code is untested, I do plan to do this. But I figured I'd first get the updated code out.
Closes #551 & #2295.