fix(boundary): guard cancel on unable to authorize connection - #6780
Open
shoemoney wants to merge 1 commit into
Open
fix(boundary): guard cancel on unable to authorize connection#6780shoemoney wants to merge 1 commit into
shoemoney wants to merge 1 commit into
Conversation
Fix verified RED->GREEN. Start() unconditionally cancels context on unable to authorize connection killing all active connections at proxy.go:286
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes proxy cancel storm when authorization fails.
Bug: Start() calls p.cancel() unconditionally for any runTcpProxyV1 error at proxy.go:286, including unable to authorize connection. This kills all active connections even though existing sessions remain valid. websocket.go already handles this case by signaling connsLeft 0 without canceling.
Fix: Guard p.cancel() with strings.Contains check for unable to authorize connection, allowing active connections to continue while preventing new ones.
Evidence: Verified RED to GREEN. go test ./proxy passes on stashed baseline and patched tree (3.02s). Formatter blast radius limited to api/proxy/proxy.go.