Skip to content

ci: scope push lint to new issues - #14

Merged
kantorcodes merged 1 commit into
mainfrom
feat/main-push-lint-fix
Apr 10, 2026
Merged

kantorcodes merged 1 commit into
mainfrom
feat/main-push-lint-fix

Conversation

@kantorcodes

Copy link
Copy Markdown
Member

Summary

  • fix the main-branch lint gate so push builds only fail on newly introduced lint issues
  • use github.event.before for push events, matching the existing diff-based PR lint strategy
  • unblock release jobs on main without masking new regressions

Verification

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/ci.yml")'
  • $(go env GOPATH)/bin/golangci-lint run --new-from-rev origin/main ./...

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@kantorcodes
kantorcodes merged commit 9900593 into main Apr 10, 2026
10 checks passed
@kantorcodes
kantorcodes deleted the feat/main-push-lint-fix branch April 10, 2026 14:41
Comment thread .github/workflows/ci.yml
with:
version: v1.64.8
install-mode: goinstall
args: --new-from-rev=${{ github.event.before }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Unvalidated github.event.before may be empty or invalid for certain push events (e.g., first push to a new branch, force pushes). This can cause the lint command to fail.

Consider adding a fallback or validation to handle these edge cases.

@kilo-code-bot

kilo-code-bot Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
.github/workflows/ci.yml 40 Unvalidated github.event.before may be empty or invalid for certain push events
Files Reviewed (1 file)
  • .github/workflows/ci.yml - 1 issue

Fix these issues in Kilo Cloud


Reviewed by minimax-m2.5-20260211 · 208,152 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant