test: document official inscriber execute limitation - #13
Closed
kantorcodes wants to merge 1 commit into
Closed
kantorcodes wants to merge 1 commit into
kantorcodes wants to merge 1 commit into
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by minimax-m2.5-20260211 · 242,768 tokens |
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration test, TestInscriberIntegration_OfficialSDKPresignedTransferExecute, in pkg/inscriber/integration_official_sdk_test.go. The test verifies the behavior of presigned transfer transactions for inscriptions, confirming that the official Hedera SDK's Execute method fails as expected with an INVALID_SIGNATURE error for third-party payer transfers, while the custom ExecuteTransaction function succeeds. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransactionFromBytes+AddSignatureV2+Executepath still fails withINVALID_SIGNATUREExecuteTransactionpath succeeds on the exact same payloadVerification
go test ./pkg/inscriber -run TestInscriberIntegration_OfficialSDKPresignedTransferExecute -count=1RUN_INTEGRATION=1 RUN_INSCRIBER_INTEGRATION=1 go test ./pkg/inscriber -run TestInscriberIntegration_OfficialSDKPresignedTransferExecute -count=1 -vRUN_INTEGRATION=1 go test ./pkg/hcs27 -run "TestHCS27Integration_(CheckpointChain|MetadataOverflowUsesHRL)" -count=1 -vNotes
.env