Skip to content

test: document official inscriber execute limitation - #13

Closed
kantorcodes wants to merge 1 commit into
mainfrom
feat/inscriber-official-sdk-investigation
Closed

kantorcodes wants to merge 1 commit into
mainfrom
feat/inscriber-official-sdk-investigation

Conversation

@kantorcodes

Copy link
Copy Markdown
Member

Summary

  • add a live inscriber integration that exercises the official Hiero SDK submit path for third-party payer inscription transfers
  • prove the official TransactionFromBytes + AddSignatureV2 + Execute path still fails with INVALID_SIGNATURE
  • prove the existing ExecuteTransaction path succeeds on the exact same payload

Verification

  • go test ./pkg/inscriber -run TestInscriberIntegration_OfficialSDKPresignedTransferExecute -count=1
  • RUN_INTEGRATION=1 RUN_INSCRIBER_INTEGRATION=1 go test ./pkg/inscriber -run TestInscriberIntegration_OfficialSDKPresignedTransferExecute -count=1 -v
  • RUN_INTEGRATION=1 go test ./pkg/hcs27 -run "TestHCS27Integration_(CheckpointChain|MetadataOverflowUsesHRL)" -count=1 -v

Notes

  • live testnet verification used the funded existing operator account from repo .env
  • no secrets were committed or inlined

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kantorcodes
kantorcodes deleted the feat/inscriber-official-sdk-investigation branch April 10, 2026 14:37
@kilo-code-bot

kilo-code-bot Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • pkg/inscriber/integration_official_sdk_test.go

Reviewed by minimax-m2.5-20260211 · 242,768 tokens

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new integration test, TestInscriberIntegration_OfficialSDKPresignedTransferExecute, in pkg/inscriber/integration_official_sdk_test.go. The test verifies the behavior of presigned transfer transactions for inscriptions, confirming that the official Hedera SDK's Execute method fails as expected with an INVALID_SIGNATURE error for third-party payer transfers, while the custom ExecuteTransaction function succeeds. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant