fix: align go inscriber auth with TypeScript parity - #12
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request introduces new transaction execution strategies for the Hedera inscriber, including direct gRPC submission of serialized transactions and a pass-through execution mode. It also refactors authentication header handling and expands private key parsing capabilities. Key feedback includes addressing a potential nil pointer panic when appending signatures, fixing redundant error reporting logic, and improving security by avoiding hardcoded insecure TLS verification. Additionally, the reviewer noted that hardcoding node addresses is brittle and should be replaced with a more robust discovery mechanism.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 files)
Reviewed by minimax-m2.5-20260211 · 68,078 tokens |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f25d91fdb0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72b2e81fb3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if receiptErr != nil { | ||
| return "", fmt.Errorf( | ||
| "submitted serialized transaction %s but failed to fetch receipt: %w", |
There was a problem hiding this comment.
Avoid failing after successful precheck on receipt lookup errors
Once CryptoTransfer returns OK, the transaction is already accepted by a node, but this block immediately returns an error if the first receipt query fails (for example RECEIPT_NOT_FOUND, transient node lag, or a tight context deadline). ExecuteTransaction then falls through to other execution strategies and can surface a hard failure (often duplicate-precheck errors) even though the original submission later reaches consensus, so callers can be told the transfer failed when it actually succeeded.
Useful? React with 👍 / 👎.
Summary
Verification
Notes
0.0.2656337.0.0.2659396in the returned transaction IDs, which is expected upstream behavior and not the operator account used by the SDK.