feat: add skill growth endpoints to go registry broker client

[kantorcodes]

Summary

• add Go registry broker client support for skill status, preview, quote-preview, conversion signals, and preview upload
• add focused contract tests plus a gated live test for the new endpoints
• verify the new methods against production hol.org endpoints

Verification

• go test ./pkg/registrybroker -run "Test(GetSkillStatusParsesLifecycleSignals|SkillPreviewEndpointsUseCanonicalPaths)$"
• HASHNET_LIVE_TESTS=1 go test ./pkg/registrybroker -run TestLiveSkillGrowthEndpoints

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)

• pkg/registrybroker/skills_status.go - New implementation with skill status, preview, quote-preview, conversion signals, and preview upload endpoints with proper input validation
• pkg/registrybroker/skills_status_types.go - Type definitions with appropriate JSON tags for request/response handling
• pkg/registrybroker/skills_status_test.go - Comprehensive unit tests covering all endpoints with mocked HTTP responses
• pkg/registrybroker/skills_status_live_test.go - Live tests properly gated with HASHNET_LIVE_TESTS

Notes

The implementation follows the existing patterns in the codebase:

• Uses ensureNonEmpty for required string validation
• Uses strings.TrimSpace for input sanitization
• Validates numeric fields (fileCount, totalBytes > 0)
• Uses requestTypedStatusJSON helper for HTTP calls
• Tests use httptest.Server for controlled testing
• Live tests are properly gated with HASHNET_LIVE_TESTS environment variable

The previous inline comments about "useless assignments" at lines 81, 119, 158 do not apply to this code - those comments were from a previous review on a different commit. In the current implementation, the query variable is properly used via pathWithQuery.

---

_{Reviewed by minimax-m2.5-20260211 · 532,457 tokens}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e924d3588c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[gemini-code-assist]

Code Review

This pull request introduces several new methods to the RegistryBrokerClient for managing skill statuses, previews, and quotes, along with their associated data structures and tests. The feedback identifies a redundant content-type header in the QuoteSkillPublishPreview method and notes that the requestTypedJSON helper function is not defined in the current package, which would cause compilation issues.