ci: verify go releases end to end - #10
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
|
|
||
| tag="${{ steps.release_tag.outputs.tag }}" | ||
| docs_line="- Standards SDK docs: ${HOL_SDK_DOCS_URL}" | ||
| release_notes="$(printf '## Documentation\n%s\n' "${docs_line}")" |
There was a problem hiding this comment.
WARNING: --generate-notes and --notes flags used together when creating release. When both are specified, --notes takes precedence and GitHub will not generate any release notes.
The documentation header with --generate-notes will be lost.
| fi | ||
|
|
||
| body="$(gh release view "${tag}" --json body --jq '.body // ""')" | ||
| if printf '%s' "${body}" | grep -Fq "${HOL_SDK_DOCS_URL}"; then |
There was a problem hiding this comment.
SUGGESTION: The grep -Fq check is exact string matching. Consider using a case-insensitive search (grep -Fi) to handle potential case variations in the release body format.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address comments before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)No other issues found in the codebase that couldn't receive inline comments. Files Reviewed (1 file)
Fix these issues in Kilo Cloud Reviewed by minimax-m2.5-20260211 · 239,437 tokens |
1 participant
Summary
Verification